linux-kernel - Re: [PATCH 2/2] perf tools: remove perf_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 10:43:52 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     James Clark <james.clark@....com>
Cc:     Gaosheng Cui <cuigaosheng1@...wei.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        peterz@...radead.org, mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        namhyung@...nel.org, atrajeev@...ux.vnet.ibm.com,
        eranian@...gle.com
Subject: Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration

Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> 
> 
> On 09/09/2022 05:45, Gaosheng Cui wrote:
> > perf_pmu_lex has been removed since
> > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > so remove it.
> 
> Not 100% sure if that is the right commit to reference because it didn't
> touch pmu.y.

Yeah, indeed, unsure if at that time the declaration was needed.
 
> perf_pmu_lex is still used and there are plenty of references to it, but
> maybe the extern declaration isn't needed anymore because it still
> builds for me with this change.

Ditto here, I'll remove the reference and rewrite the cset log a bit.

- Arnaldo