| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Sep 2022 21:29:05 +0800
From: kernel test robot <lkp@...el.com>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org, Kalle Valo <kvalo@...eaurora.org>
Subject: drivers/net/wireless/realtek/rtw89/coex.c:3244:25: warning: variable
'cnt_connecting' set but not used
Hi Ping-Ke,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ce888220d5c7a805e0e155302a318d5d23e62950
commit: e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd rtw89: add Realtek 802.11ax driver
date: 11 months ago
config: powerpc-allmodconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/net/wireless/realtek/rtw89/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/realtek/rtw89/coex.c:3244:25: warning: variable 'cnt_connecting' set but not used [-Wunused-but-set-variable]
u8 i, cnt_connect = 0, cnt_connecting = 0, cnt_active = 0;
^
1 warning generated.
vim +/cnt_connecting +3244 drivers/net/wireless/realtek/rtw89/coex.c
3236
3237 static void _update_wl_info(struct rtw89_dev *rtwdev)
3238 {
3239 struct rtw89_btc *btc = &rtwdev->btc;
3240 struct rtw89_btc_wl_info *wl = &btc->cx.wl;
3241 struct rtw89_btc_wl_link_info *wl_linfo = wl->link_info;
3242 struct rtw89_btc_wl_role_info *wl_rinfo = &wl->role_info;
3243 struct rtw89_btc_wl_dbcc_info *wl_dinfo = &wl->dbcc_info;
> 3244 u8 i, cnt_connect = 0, cnt_connecting = 0, cnt_active = 0;
3245 u8 cnt_2g = 0, cnt_5g = 0, phy;
3246 u32 wl_2g_ch[2] = {0}, wl_5g_ch[2] = {0};
3247 bool b2g = false, b5g = false, client_joined = false;
3248
3249 memset(wl_rinfo, 0, sizeof(*wl_rinfo));
3250
3251 for (i = 0; i < RTW89_MAX_HW_PORT_NUM; i++) {
3252 /* check if role active? */
3253 if (!wl_linfo[i].active)
3254 continue;
3255
3256 cnt_active++;
3257 wl_rinfo->active_role[cnt_active - 1].role = wl_linfo[i].role;
3258 wl_rinfo->active_role[cnt_active - 1].pid = wl_linfo[i].pid;
3259 wl_rinfo->active_role[cnt_active - 1].phy = wl_linfo[i].phy;
3260 wl_rinfo->active_role[cnt_active - 1].band = wl_linfo[i].band;
3261 wl_rinfo->active_role[cnt_active - 1].noa = (u8)wl_linfo[i].noa;
3262 wl_rinfo->active_role[cnt_active - 1].connected = 0;
3263
3264 wl->port_id[wl_linfo[i].role] = wl_linfo[i].pid;
3265
3266 phy = wl_linfo[i].phy;
3267
3268 /* check dbcc role */
3269 if (rtwdev->dbcc_en && phy < RTW89_PHY_MAX) {
3270 wl_dinfo->role[phy] = wl_linfo[i].role;
3271 wl_dinfo->op_band[phy] = wl_linfo[i].band;
3272 _update_dbcc_band(rtwdev, phy);
3273 _fw_set_drv_info(rtwdev, CXDRVINFO_DBCC);
3274 }
3275
3276 if (wl_linfo[i].connected == MLME_NO_LINK) {
3277 continue;
3278 } else if (wl_linfo[i].connected == MLME_LINKING) {
3279 cnt_connecting++;
3280 } else {
3281 cnt_connect++;
3282 if ((wl_linfo[i].role == RTW89_WIFI_ROLE_P2P_GO ||
3283 wl_linfo[i].role == RTW89_WIFI_ROLE_AP) &&
3284 wl_linfo[i].client_cnt > 1)
3285 client_joined = true;
3286 }
3287
3288 wl_rinfo->role_map.val |= BIT(wl_linfo[i].role);
3289 wl_rinfo->active_role[cnt_active - 1].ch = wl_linfo[i].ch;
3290 wl_rinfo->active_role[cnt_active - 1].bw = wl_linfo[i].bw;
3291 wl_rinfo->active_role[cnt_active - 1].connected = 1;
3292
3293 /* only care 2 roles + BT coex */
3294 if (wl_linfo[i].band != RTW89_BAND_2G) {
3295 if (cnt_5g <= ARRAY_SIZE(wl_5g_ch) - 1)
3296 wl_5g_ch[cnt_5g] = wl_linfo[i].ch;
3297 cnt_5g++;
3298 b5g = true;
3299 } else {
3300 if (cnt_2g <= ARRAY_SIZE(wl_2g_ch) - 1)
3301 wl_2g_ch[cnt_2g] = wl_linfo[i].ch;
3302 cnt_2g++;
3303 b2g = true;
3304 }
3305 }
3306
3307 wl_rinfo->connect_cnt = cnt_connect;
3308
3309 /* Be careful to change the following sequence!! */
3310 if (cnt_connect == 0) {
3311 wl_rinfo->link_mode = BTC_WLINK_NOLINK;
3312 wl_rinfo->role_map.role.none = 1;
3313 } else if (!b2g && b5g) {
3314 wl_rinfo->link_mode = BTC_WLINK_5G;
3315 } else if (wl_rinfo->role_map.role.nan) {
3316 wl_rinfo->link_mode = BTC_WLINK_2G_NAN;
3317 } else if (cnt_connect > BTC_TDMA_WLROLE_MAX) {
3318 wl_rinfo->link_mode = BTC_WLINK_OTHER;
3319 } else if (b2g && b5g && cnt_connect == 2) {
3320 if (rtwdev->dbcc_en) {
3321 switch (wl_dinfo->role[RTW89_PHY_0]) {
3322 case RTW89_WIFI_ROLE_STATION:
3323 wl_rinfo->link_mode = BTC_WLINK_2G_STA;
3324 break;
3325 case RTW89_WIFI_ROLE_P2P_GO:
3326 wl_rinfo->link_mode = BTC_WLINK_2G_GO;
3327 break;
3328 case RTW89_WIFI_ROLE_P2P_CLIENT:
3329 wl_rinfo->link_mode = BTC_WLINK_2G_GC;
3330 break;
3331 case RTW89_WIFI_ROLE_AP:
3332 wl_rinfo->link_mode = BTC_WLINK_2G_AP;
3333 break;
3334 default:
3335 wl_rinfo->link_mode = BTC_WLINK_OTHER;
3336 break;
3337 }
3338 } else {
3339 wl_rinfo->link_mode = BTC_WLINK_25G_MCC;
3340 }
3341 } else if (!b5g && cnt_connect == 2) {
3342 if (wl_rinfo->role_map.role.station &&
3343 (wl_rinfo->role_map.role.p2p_go ||
3344 wl_rinfo->role_map.role.p2p_gc ||
3345 wl_rinfo->role_map.role.ap)) {
3346 if (wl_2g_ch[0] == wl_2g_ch[1])
3347 wl_rinfo->link_mode = BTC_WLINK_2G_SCC;
3348 else
3349 wl_rinfo->link_mode = BTC_WLINK_2G_MCC;
3350 } else {
3351 wl_rinfo->link_mode = BTC_WLINK_2G_MCC;
3352 }
3353 } else if (!b5g && cnt_connect == 1) {
3354 if (wl_rinfo->role_map.role.station)
3355 wl_rinfo->link_mode = BTC_WLINK_2G_STA;
3356 else if (wl_rinfo->role_map.role.ap)
3357 wl_rinfo->link_mode = BTC_WLINK_2G_AP;
3358 else if (wl_rinfo->role_map.role.p2p_go)
3359 wl_rinfo->link_mode = BTC_WLINK_2G_GO;
3360 else if (wl_rinfo->role_map.role.p2p_gc)
3361 wl_rinfo->link_mode = BTC_WLINK_2G_GC;
3362 else
3363 wl_rinfo->link_mode = BTC_WLINK_OTHER;
3364 }
3365
3366 /* if no client_joined, don't care P2P-GO/AP role */
3367 if (wl_rinfo->role_map.role.p2p_go || wl_rinfo->role_map.role.ap) {
3368 if (!client_joined) {
3369 if (wl_rinfo->link_mode == BTC_WLINK_2G_SCC ||
3370 wl_rinfo->link_mode == BTC_WLINK_2G_MCC) {
3371 wl_rinfo->link_mode = BTC_WLINK_2G_STA;
3372 wl_rinfo->connect_cnt = 1;
3373 } else if (wl_rinfo->link_mode == BTC_WLINK_2G_GO ||
3374 wl_rinfo->link_mode == BTC_WLINK_2G_AP) {
3375 wl_rinfo->link_mode = BTC_WLINK_NOLINK;
3376 wl_rinfo->connect_cnt = 0;
3377 }
3378 }
3379 }
3380
3381 rtw89_debug(rtwdev, RTW89_DBG_BTC,
3382 "[BTC], cnt_connect = %d, link_mode = %d\n",
3383 cnt_connect, wl_rinfo->link_mode);
3384
3385 _fw_set_drv_info(rtwdev, CXDRVINFO_ROLE);
3386 }
3387
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (299227 bytes)
Powered by blists - more mailing lists