linux-kernel - Re: [PATCH v2 RESEND] locking/lockref/x86: Enable ARCH_USE_CMPXCHG_LOCKREF for X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiEQeRuAwHYOS6oBmewLBXg6Nd6xMPmMz2E75f660TDSA@mail.gmail.com>
Date:   Sat, 10 Sep 2022 13:23:25 -0400
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Uros Bizjak <ubizjak@...il.com>
Cc:     "the arch/x86 maintainers" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2 RESEND] locking/lockref/x86: Enable ARCH_USE_CMPXCHG_LOCKREF
 for X86_CMPXCHG64

On Sat, Sep 10, 2022 at 2:28 AM Uros Bizjak <ubizjak@...il.com> wrote:
>
> May I consider this message as a formal Acked-by: for the patch? I'll
> resubmit the patch with a commit message updated to reference
> lockref_put_not_zero instead of the removed lockref_get_or_lock.

Sure, sounds good to me.

It would be particularly nice if you can also see any change in
performance numbers - but that simply may not be possible.

32-bit x86 tends to also be very low core count, so the whole lockref
thing may or may not be measurable (no practical contention on the
lock), but the code certainly seems to get better.

             Linus