linux-kernel - Re: [PATCH v3 7/9] arm64: dts: qcom: sm6115: Add basic soc dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Sep 2022 12:09:00 +0300
From:   Iskren Chernev <iskren.chernev@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/9] arm64: dts: qcom: sm6115: Add basic soc dtsi



On 9/11/22 11:40, Krzysztof Kozlowski wrote:
> On 10/09/2022 16:32, Iskren Chernev wrote:
>> Add support for Qualcomm SM6115 SoC. This includes:
>> - GCC
>> - Pinctrl
>> - RPM (CC+PD)
>> - USB
>> - MMC
>> - UFS
>>
>> Signed-off-by: Iskren Chernev <iskren.chernev@...il.com>
>> ---
>> pending issues with dtschema:
>> - for some reason, using pinctrl phandles (in mmc) breaks the pinctrl
>>   schema (4 times)
>>       .output/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dtb: pinctrl@...000: sdc1-on-state: 'oneOf' conditional failed, one must be fixed:
>>             'pins' is a required property
>>             'clk', 'cmd', 'data', 'rclk' do not match any of the regexes: 'pinctrl-[0-9]+'
>>             [[26]] is not of type 'object'
>>             From schema: /home/iskren/src/pmos/linux-postmarketos/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
>
> It's the same as 06367559766b7c9bd96d2baef8bfc5a9bb451e25. I propose to
> fix it the same way. I can do a biger change for all pinctrls, so here
> you would need to add "-pins" prefix to entries (see patch
> 4fcdaf4b0320f93d0ccb4d36b795ed258fb07b27).

OK, that makes sense. One thing that is a bit odd -- the current pattern
"(pinconf|-pins)$" matches anything that ends in pinconf OR -pins (so it could
be sth-pinconf). Also, if you only have a single block, isn't the idea to just
list it in the -states node.  I mean we either force everybody to nest with
a pinconf, or we allow -pins for nested stuff and directly in -state for the
non-nested. Just my 2c.

> Best regards,
> Krzysztof