linux-kernel - Re: [PATCH V2] efi: efibc: Guard against allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8ce8fb4-baac-b3a5-5d6d-418e20c8d2d9@igalia.com>
Date:   Sun, 11 Sep 2022 11:36:00 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     ardb@...nel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-efi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-dev@...lia.com,
        kernel@...ccoli.net, matt@...eblueprint.co.uk, mjg59@...f.ucam.org
Subject: Re: [PATCH V2] efi: efibc: Guard against allocation failure

On 10/09/2022 01:56, Christophe JAILLET wrote:
> [...]
>>   	wdata = kmalloc(MAX_DATA_LEN * sizeof(efi_char16_t), GFP_KERNEL);
> Hi,
> 
> even if mostly useless in this case, kmalloc_array()?
> 
> Or certainly maybe even better, kstrndup()?
> 
> CJ
> 

Thanks! It's up to Ard, I could rework with this change if makes sense.
Cheers,


Guilherme