linux-kernel - Re: [PATCH v4 16/26] KVM: kvm_arch.c: Remove a global variable, hardware_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220911030052.GB873583@ls.amr.corp.intel.com>
Date:   Sat, 10 Sep 2022 20:00:52 -0700
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     Chao Gao <chao.gao@...el.com>
Cc:     isaku.yamahata@...el.com, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Marc Zyngier <maz@...nel.org>, Will Deacon <will@...nel.org>,
        Yuan Yao <yuan.yao@...ux.intel.com>, isaku.yamahata@...il.com,
        Kai Huang <kai.huang@...el.com>,
        Atish Patra <atishp@...shpatra.org>,
        Shaokun Zhang <zhangshaokun@...ilicon.com>,
        Qi Liu <liuqi115@...wei.com>,
        John Garry <john.garry@...wei.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Huang Ying <ying.huang@...el.com>,
        Huacai Chen <chenhuacai@...nel.org>
Subject: Re: [PATCH v4 16/26] KVM: kvm_arch.c: Remove a global variable,
 hardware_enable_failed

On Fri, Sep 09, 2022 at 02:54:05PM +0800,
Chao Gao <chao.gao@...el.com> wrote:

> >diff --git a/virt/kvm/kvm_arch.c b/virt/kvm/kvm_arch.c
> >index 4fe16e8ef2e5..ad23537ebe3b 100644
> >--- a/virt/kvm/kvm_arch.c
> >+++ b/virt/kvm/kvm_arch.c
> >@@ -13,14 +13,13 @@
> > #include <linux/kvm_host.h>
> > 
> > static cpumask_t cpus_hardware_enabled = CPU_MASK_NONE;
> >-static atomic_t hardware_enable_failed;
> > 
> > __weak int kvm_arch_post_init_vm(struct kvm *kvm)
> > {
> > 	return 0;
> > }
> > 
> >-static void hardware_enable(void *caller_name)
> >+static int __hardware_enable(void *caller_name)
> 
> nit: caller_name can be dropped and use __builtin_return_address(0) instead.

Do you want to update your patch
"KVM: Provide more information in kernel log if hardware enabling fails"?
-- 
Isaku Yamahata <isaku.yamahata@...il.com>