linux-kernel - Re: [PATCH v2 2/8] ARM: dts: uniphier: Rename usb-phy node to usb-glue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2a386281-5a49-4df6-bafe-ef9de0fb0ca5@www.fastmail.com>
Date:   Mon, 12 Sep 2022 10:32:16 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Kunihiko Hayashi" <hayashi.kunihiko@...ionext.com>,
        soc@...nel.org, "Olof Johansson" <olof@...om.net>
Cc:     "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "Masami Hiramatsu" <mhiramat@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/8] ARM: dts: uniphier: Rename usb-phy node to usb-glue

On Mon, Sep 12, 2022, at 9:15 AM, Kunihiko Hayashi wrote:
> Actual phy nodes are each child node. The parent node should be usb-glue
> node. This applies to the devicetre for Pro4 SoC.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> ---
>  arch/arm/boot/dts/uniphier-pro4.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/uniphier-pro4.dtsi 
> b/arch/arm/boot/dts/uniphier-pro4.dtsi
> index a53b73ee93e9..cf62821c69ca 100644
> --- a/arch/arm/boot/dts/uniphier-pro4.dtsi
> +++ b/arch/arm/boot/dts/uniphier-pro4.dtsi
> @@ -376,7 +376,7 @@ pinctrl: pinctrl {
>  				compatible = "socionext,uniphier-pro4-pinctrl";
>  			};
> 
> -			usb-phy {
> +			usb-glue {
>  				compatible = "socionext,uniphier-pro4-usb2-phy";
>  				#address-cells = <1>;
>  				#size-cells = <0>;

Not sure about this one. What hardware does this node
actaully represent? I don't see any other soc dts files
refer to node names as 'glue', so there is probably a
better name for it. In the binding document, it's called
"usb-controller", but I'm not sure that is the right name
either.

      Arnd