linux-kernel - Re: [RFT] [PATCH] regulator: tps65219: Fix .bypass_val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8a92b6d-ad23-24e7-2a01-73839e57cb85@baylibre.com>
Date:   Mon, 12 Sep 2022 11:49:09 +0200
From:   jerome Neanne <jneanne@...libre.com>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFT] [PATCH] regulator: tps65219: Fix .bypass_val_on setting

Hi Axel,

On 28/08/2022 14:01, Axel Lin wrote:
> The .bypass_val_on setting does not match the .bypass_mask setting, so the
> .bypass_mask bit will never get set.  Fix it by removing .bypass_val_on
> setting, the regulator_set_bypass_regmap and regulator_get_bypass_regmap
> helpers will use rdev->desc->bypass_mask as val_on if the val_on is 0.
I think this will result in exact same behavior. val would be assigned 
to 1 when enable is set and 0 otherwise. Anyway you are right this line 
is useless.
> I don't have this h/w to test, please help to review and test the patch.

I'll double check on the board.