linux-kernel - Re: [PATCH v2 3/4] dt-bindings: remoteproc: qcom: wcnss: Add qcom,pronto compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2022 09:03:53 +0530
From:   "Sireesh Kodali" <sireeshkodali1@...il.com>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        <devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>,
        <~postmarketos/upstreaming@...ts.sr.ht>
Cc:     <bjorn.andersson@...aro.org>, "Andy Gross" <agross@...nel.org>,
        "Konrad Dybcio" <konrad.dybcio@...ainline.org>,
        "Mathieu Poirier" <mathieu.poirier@...aro.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: remoteproc: qcom: wcnss: Add
 qcom,pronto compatible

On Fri Sep 9, 2022 at 1:30 PM IST, Krzysztof Kozlowski wrote:
> On 08/09/2022 20:49, Sireesh Kodali wrote:
> > The qcom,pronto compatible is used in the wcn36xx driver to determine
> > which register to access. However, this compatible was not documented.
> > This patch documents the existing compatible as is, since it isn't
> > immediately clear why the wcn36xx driver uses this extra compatible,
> > rather than relying directly on the regular compatible string.
>
> The patch does much more - messes entirely all compatibles...

Is there another preferred way to handle this?
>
> > 
> > Signed-off-by: Sireesh Kodali <sireeshkodali1@...il.com>
> > ---
> >  .../bindings/remoteproc/qcom,wcnss-pil.yaml      | 16 ++++++++++++----
> >  1 file changed, 12 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
> > index bc18139fdb91..5e4a97e9d330 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
> > @@ -15,10 +15,18 @@ description:
> >  
> >  properties:
> >    compatible:
> > -    enum:
> > -      - qcom,riva-pil
> > -      - qcom,pronto-v1-pil
> > -      - qcom,pronto-v2-pil
> > +    description:
> > +      Append "qcom,pronto" if the device is actually pronto, and not riva
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - qcom,pronto-v1-pil
> > +              - qcom,pronto-v2-pil
> > +          - enum:
> > +              - qcom,pronto
>
> It's const, not enum.
>
> > +      - items:
>
> No items.

Both these things will be fixed in v3
>
> > +          - enum:
> > +              - qcom,riva-pil
>
>
> Best regards,
> Krzysztof