linux-kernel - Re: [PATCH] power: supply: ab8500: remove unused static local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220911123443.uyezfayi2qwtlhmo@mercury.elektranox.org>
Date:   Sun, 11 Sep 2022 14:34:43 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Tom Rix <trix@...hat.com>
Cc:     linus.walleij@...aro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: ab8500: remove unused static local
 variable

Hi,

On Mon, Jul 18, 2022 at 10:27:43PM -0400, Tom Rix wrote:
> cpp_check reports
> [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_chargalg_ex_ac_enable_toggle' is assigned a value that is never used.
> 
> From inspection, this variable is never used. So remove it.
> 
> Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftovers")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---

Thanks, queued into power-supply's fixes branch.
Sorry for the delay.

-- Sebastian

>  drivers/power/supply/ab8500_chargalg.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c
> index ae4be553f424..05146d436a6a 100644
> --- a/drivers/power/supply/ab8500_chargalg.c
> +++ b/drivers/power/supply/ab8500_chargalg.c
> @@ -490,8 +490,6 @@ static int ab8500_chargalg_kick_watchdog(struct ab8500_chargalg *di)
>  static int ab8500_chargalg_ac_en(struct ab8500_chargalg *di, int enable,
>  	int vset_uv, int iset_ua)
>  {
> -	static int ab8500_chargalg_ex_ac_enable_toggle;
> -
>  	if (!di->ac_chg || !di->ac_chg->ops.enable)
>  		return -ENXIO;
>  
> -- 
> 2.27.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)