linux-kernel - Re: [PATCH linux-next] speakup/utils: use "!P" instead of "P == 0"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220912110258.jwyv4xenfdvmo3p3@begin>
Date:   Mon, 12 Sep 2022 13:02:58 +0200
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     cgel.zte@...il.com
Cc:     w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
        Cspeakup@...ux-speakup.org, linux-kernel@...r.kernel.org,
        Xu Panda <xu.panda@....com.cn>, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] speakup/utils: use "!P" instead of "P == 0"

cgel.zte@...il.com, le lun. 12 sept. 2022 10:21:00 +0000, a ecrit:
> From: Xu Panda <xu.panda@....com.cn>
> 
> comparing pointer to 0, use !P instead of it.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Xu Panda <xu.panda@....com.cn>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..58ca9847637f 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
>         else
>                 snprintf(filename, sizeof(filename), "%s", name);
>         infile = fopen(filename, "r");
> -       if (infile == 0) {
> +       if (!infile) {
>                 fprintf(stderr, "can't open %s\n", filename);
>                 exit(1);
>         }
> -- 
> 2.15.2
>