linux-kernel - Re: [PATCH] ia64: export memory_add_physaddr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <687a977d-81a4-497e-86ba-b63ff4cad518@www.fastmail.com>
Date:   Mon, 12 Sep 2022 15:53:54 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Randy Dunlap" <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org
Cc:     "kernel test robot" <lkp@...el.com>,
        "Dan Williams" <dan.j.williams@...el.com>,
        "Ben Widawsky" <bwidawsk@...nel.org>,
        "Jonathan Cameron" <Jonathan.Cameron@...wei.com>,
        linux-ia64@...r.kernel.org, "Keith Mannthey" <kmannth@...ibm.com>,
        "Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH] ia64: export memory_add_physaddr_to_nid to fix cxl build error

On Sun, Sep 11, 2022, at 3:26 AM, Randy Dunlap wrote:
> cxl_pmem.ko uses memory_add_physaddr_to_nid() but ia64 does not export it,
> so this causes a build error:
>
> ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/cxl/cxl_pmem.ko] 
> undefined!
>
> Fix this by exporting that function.
>
> Fixes: 8c2676a5870a ("hot-add-mem x86_64: memory_add_physaddr_to_nid 
> node fixup")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Ben Widawsky <bwidawsk@...nel.org>
> Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Cc: linux-ia64@...r.kernel.org
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Keith Mannthey <kmannth@...ibm.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---
> Arnd, can you take this in your one-off fixes arch tree, or would
> you prefer for Andrew to take it?

I've applied it to the asm-generic tree for 6.1 now, as I don't
expect any other bugfixes for 6.0 to go through that tree. It's
clearly a bugfix, but since the original commit you cite was from
2006, I assume it can wait a little longer.

     Arnd