lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Sep 2022 17:06:27 +0200 From: Philipp Zabel <philipp.zabel@...il.com> To: "Limonciello, Mario" <Mario.Limonciello@....com> Cc: "rafael@...nel.org" <rafael@...nel.org>, "catalin@...ebit.com" <catalin@...ebit.com>, "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>, Len Brown <lenb@...nel.org>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 0/4] Fixups for s2idle on ASUS Rembrandt laptop Am Mon, Sep 12, 2022 at 02:58:51PM +0000 schrieb Limonciello, Mario: > [AMD Official Use Only - General] > > > > > -----Original Message----- > > From: Philipp Zabel <philipp.zabel@...il.com> > > Sent: Monday, September 12, 2022 09:57 > > To: Limonciello, Mario <Mario.Limonciello@....com> > > Cc: rafael@...nel.org; catalin@...ebit.com; S-k, Shyam-sundar <Shyam- > > sundar.S-k@....com>; Len Brown <lenb@...nel.org>; linux- > > acpi@...r.kernel.org; linux-kernel@...r.kernel.org > > Subject: Re: [PATCH 0/4] Fixups for s2idle on ASUS Rembrandt laptop > > > > Hi Mario, > > > > Am Fri, Sep 09, 2022 at 01:05:05PM -0500 schrieb Mario Limonciello: > > > It was reported that an ASUS Rembrandt laptop has problems with > > seemingly > > > unrelated ACPI events after resuming from s2idle. Debugging the issue > > > proved it's because ASUS has ASL that is only called when using the > > > Microsoft GUID, not the AMD GUID. > > > > > > This is a bug from ASUS firmware but this series reworks the s2idle > > > handling for AMD to allow accounting for this in a quirk. > > > > > > Additionally as this is a problem that may pop up again on other models > > > add a module parameter that can be used to try the Microsoft GUID on a > > > given system. > > > > thank you, these also helped on an ASUS ROG Zephyrus G14 (2022) with > > BIOS version GA402RJ.313. Patches 1-3 > > > > Tested-by: Philipp Zabel <philipp.zabel@...il.com> # GA402RJ > > Did you use acpi.prefer_microsoft_guid=1 for your system then too? > > If so, I should re-spin this series to add your system's quirk to patch 4. Yes. I also tested with the following diff applied instead of the module parameter: ----------8<---------- diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c index 6a2c94fdbeae..a247560e31de 100644 --- a/drivers/acpi/x86/s2idle.c +++ b/drivers/acpi/x86/s2idle.c @@ -420,6 +420,14 @@ static const struct dmi_system_id s2idle_dmi_table[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "ASUS TUF Gaming A17"), }, }, + { + /* ASUS ROG Zephyrus G14 (2022) */ + .callback = lps0_prefer_microsoft, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus G14 GA402"), + }, + }, {} }; ---------->8---------- The full DMI Product Name is "ROG Zephyrus G14 GA402RJ_GA402RJ", but there is also a near-identical higher spec model GA402RK. regards Philipp
Powered by blists - more mailing lists