linux-kernel - Re: [PATCH] drivers/misc/sgi-xp: remove unused declarations in xp.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yx9PAHL/6ptF5MDF@swahl-home.5wahls.com>
Date:   Mon, 12 Sep 2022 10:23:44 -0500
From:   Steve Wahl <steve.wahl@....com>
To:     Gaosheng Cui <cuigaosheng1@...wei.com>
Cc:     robinmholt@...il.com, steve.wahl@....com, mike.travis@....com,
        arnd@...db.de, gregkh@...uxfoundation.org, hch@....de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/misc/sgi-xp: remove unused declarations in xp.h

Shouldn't xp_nofault_PIOR be removed also, for the exact same reasons?

On Sun, Sep 11, 2022 at 05:32:12PM +0800, Gaosheng Cui wrote:
> xp_nofault_PIOR_target and xp_error_PIOR have been removed since
> commit 9726bfcdb977 ("misc/sgi-xp: remove SGI SN2 support"),
> so remove them.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> ---
>  drivers/misc/sgi-xp/xp.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-xp/xp.h b/drivers/misc/sgi-xp/xp.h
> index 9f9af77f8d2e..cf073304b714 100644
> --- a/drivers/misc/sgi-xp/xp.h
> +++ b/drivers/misc/sgi-xp/xp.h
> @@ -334,9 +334,7 @@ extern int (*xp_cpu_to_nasid) (int);
>  extern enum xp_retval (*xp_expand_memprotect) (unsigned long, unsigned long);
>  extern enum xp_retval (*xp_restrict_memprotect) (unsigned long, unsigned long);
>  
> -extern u64 xp_nofault_PIOR_target;
>  extern int xp_nofault_PIOR(void *);
> -extern int xp_error_PIOR(void);
>  
>  extern struct device *xp;
>  extern enum xp_retval xp_init_uv(void);
> -- 
> 2.25.1
> 

-- 
Steve Wahl, Hewlett Packard Enterprise