linux-kernel - Re: [PATCH -next] smack: cleanup obsolete mount option flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17db01f1-0e53-fd25-d5ca-622003ddd42c@schaufler-ca.com>
Date:   Mon, 12 Sep 2022 10:00:43 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     Xiu Jianfeng <xiujianfeng@...wei.com>, paul@...l-moore.com,
        jmorris@...ei.org, serge@...lyn.com
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, casey@...aufler-ca.com
Subject: Re: [PATCH -next] smack: cleanup obsolete mount option flags

On 9/8/2022 3:35 AM, Xiu Jianfeng wrote:
> These mount option flags are obsolete since commit 12085b14a444 ("smack:
> switch to private smack_mnt_opts"), remove them.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Added to https://github.com/cschaufler/smack-next#next.
Thank you.

> ---
>  security/smack/smack.h | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index fc837dcebf96..e2239be7bd60 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -180,15 +180,6 @@ struct smack_known_list_elem {
>  	struct smack_known	*smk_label;
>  };
>  
> -/* Super block security struct flags for mount options */
> -#define FSDEFAULT_MNT	0x01
> -#define FSFLOOR_MNT	0x02
> -#define FSHAT_MNT	0x04
> -#define FSROOT_MNT	0x08
> -#define FSTRANS_MNT	0x10
> -
> -#define NUM_SMK_MNT_OPTS	5
> -
>  enum {
>  	Opt_error = -1,
>  	Opt_fsdefault = 0,