linux-kernel - Re: [PATCH v14 67/70] mm/vmscan: Use vma iterator instead of vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220912140337.cccdea4cf67e4c4126ae158d@linux-foundation.org>
Date:   Mon, 12 Sep 2022 14:03:37 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Yu Zhao <yuzhao@...gle.com>
Cc:     Liam Howlett <liam.howlett@...cle.com>,
        "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v14 67/70] mm/vmscan: Use vma iterator instead of
 vm_next

On Mon, 12 Sep 2022 14:01:28 -0600 Yu Zhao <yuzhao@...gle.com> wrote:

> The diff between the original patch and this one, in case you prefer to
> fix it atop rather than amend.

Always...

> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index a7c5d15c1618..cadcc3290918 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3776,7 +3776,10 @@ static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk
>  	VM_WARN_ON_ONCE(mask & size);
>  	VM_WARN_ON_ONCE((start & mask) != (*vm_start & mask));
>  
> -	for_each_vma_range(vmi, args->vma, end) {
> +	for_each_vma(vmi, args->vma) {
> +		if (end && end <= args->vma->vm_start)
> +			return false;
> +
>  		if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args))
>  			continue;

Thanks.

I added your signoff so I don't get a nastygram from Stephen in the
morning.  Please send along a suitable brief changelog?