linux-kernel - Re: [PATCH] platform/chrome: cros_ec: Log wake events during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLzEksE+YVjPGG6Or0_7pE5D9o+DmmDTZ1KZap2QGKSexiJNA@mail.gmail.com>
Date:   Mon, 12 Sep 2022 14:37:36 -0700
From:   Benson Leung <bleung@...omium.org>
To:     Jameson Thies <jthies@...gle.com>
Cc:     chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
        pmalani@...omium.org, groeck@...omium.org, tzungbi@...nel.org
Subject: Re: [PATCH] platform/chrome: cros_ec: Log wake events during resume

Hi Jameson,

On Mon, Sep 12, 2022 at 2:34 PM Jameson Thies <jthies@...gle.com> wrote:
>
> Update cros_ec_report_events_during_suspend to log wake events during
> resume by calling pm_wakeup_event.
>

Minor nit, isn't it more accurate to say that this change "signals" or
"notifies" a wakeup event rather than just log? Log indicates some
print to a logging service, which may happen, but as a side effect of
the actual pm_wakeup_event call, which does something real on its own.

Thanks,
Benson

> Signed-off-by: Jameson Thies <jthies@...gle.com>
> Reviewed-by: Prashant Malani <pmalani@...omium.org>
> ---
>  drivers/platform/chrome/cros_ec.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
> index 8aace50d446d..110df0fd4b00 100644
> --- a/drivers/platform/chrome/cros_ec.c
> +++ b/drivers/platform/chrome/cros_ec.c
> @@ -349,10 +349,16 @@ EXPORT_SYMBOL(cros_ec_suspend);
>
>  static void cros_ec_report_events_during_suspend(struct cros_ec_device *ec_dev)
>  {
> +       bool wake_event;
> +
>         while (ec_dev->mkbp_event_supported &&
> -              cros_ec_get_next_event(ec_dev, NULL, NULL) > 0)
> +              cros_ec_get_next_event(ec_dev, &wake_event, NULL) > 0) {
>                 blocking_notifier_call_chain(&ec_dev->event_notifier,
>                                              1, ec_dev);
> +
> +               if (wake_event && device_may_wakeup(ec_dev->dev))
> +                       pm_wakeup_event(ec_dev->dev, 0);
> +       }
>  }
>
>  /**
> --
> 2.37.2.789.g6183377224-goog
>
>


-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org