linux-kernel - Re: [RFC Patch net-next 0/4] net: dsa: microchip: ksz9477: enable interrupt for internal phy link detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a14a0226b5cb0067fb63e69b87bc0f8a2b50a45.camel@microchip.com>
Date:   Tue, 13 Sep 2022 04:21:47 +0000
From:   <Arun.Ramadoss@...rochip.com>
To:     <andrew@...n.ch>
CC:     <olteanv@...il.com>, <linux-kernel@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>, <vivien.didelot@...il.com>,
        <linux@...linux.org.uk>, <Tristram.Ha@...rochip.com>,
        <f.fainelli@...il.com>, <kuba@...nel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <Woojung.Huh@...rochip.com>, <davem@...emloft.net>
Subject: Re: [RFC Patch net-next 0/4] net: dsa: microchip: ksz9477: enable
 interrupt for internal phy link detection

Hi Andrew, 
On Mon, 2022-09-12 at 23:33 +0200, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Fri, Sep 09, 2022 at 09:31:16PM +0530, Arun Ramadoss wrote:
> > This patch series implements the common interrupt handling for
> > ksz9477 based
> > switches and lan937x. The ksz9477 and lan937x has similar interrupt
> > registers
> > except ksz9477 has 4 port based interrupts whereas lan937x has 6
> > interrupts.
> > The patch moves the phy interrupt hanler implemented in
> > lan937x_main.c to
> > ksz_common.c, along with the mdio_register functionality.
> 
> It is a good idea to state why it is an RFC. What sort of comments do
> you want?

In the arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts file, they
haven't specified the phy-handle. If I use that dts file with this
patch, during the mdio_register I get the error *no mdio bus node* and
the ksz probe fails. If I update the dts file with phy-handle  and mdio
node, the mdio_register is successfull and interrupt handling works
fine. Do I need to add any checks before mdio_register or updating the
dts file is enough?

> 
>     Andrew