linux-kernel - Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874jxbfgfv.wl-tiwai@suse.de>
Date:   Tue, 13 Sep 2022 17:21:40 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Cezary Rojewski <cezary.rojewski@...el.com>
Cc:     Gaosheng Cui <cuigaosheng1@...wei.com>,
        <pierre-louis.bossart@...ux.intel.com>,
        <liam.r.girdwood@...ux.intel.com>,
        <peter.ujfalusi@...ux.intel.com>,
        <yung-chuan.liao@...ux.intel.com>,
        <ranjani.sridharan@...ux.intel.com>,
        <kai.vehmanen@...ux.intel.com>, <broonie@...nel.org>,
        <perex@...ex.cz>, <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec

On Tue, 13 Sep 2022 16:03:35 +0200,
Cezary Rojewski wrote:
> 
> On 2022-08-22 5:51 AM, Gaosheng Cui wrote:
> > In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n,
> > gcc warns about an unused variable:
> > 
> > sound/soc/intel/skylake/skl.c: In function ‘probe_codec’:
> > sound/soc/intel/skylake/skl.c:729:18: error: unused variable ‘skl’ [-Werror=unused-variable]
> >    struct skl_dev *skl = bus_to_skl(bus);
> >                    ^~~
> > cc1: all warnings being treated as errors
> > 
> > Fixes: 3fd63658caed9 ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
> > Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> 
> Thanks for the fix.
> 
> Acked-by: Cezary Rojewski <cezary.rojewski@...el.com>

Applied now.


Takashi