linux-kernel - Re: [PATCH] dt-bindings: pci: qcom,pcie-ep: correct qcom,perst-regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d22ed818-1a8d-4af8-d41d-2268806f3dea@linaro.org>
Date:   Tue, 13 Sep 2022 18:25:49 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Manivannan Sadhasivam <mani@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: Re: [PATCH] dt-bindings: pci: qcom,pcie-ep: correct qcom,perst-regs

On 13/09/2022 17:20, Rob Herring wrote:
> On Sun, Sep 11, 2022 at 04:14:54PM +0200, Krzysztof Kozlowski wrote:
>> On 11/09/2022 15:55, Krzysztof Kozlowski wrote:
>>> qcom,perst-regs is an phandle array of one item with a phandle and its
>>> arguments.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>  Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++--
>>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
>>> index 3d23599e5e91..077e002b07d3 100644
>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
>>> @@ -60,8 +60,10 @@ properties:
>>>                   enable registers
>>>      $ref: "/schemas/types.yaml#/definitions/phandle-array"
>>>      items:
>>> -      minItems: 3
>>> -      maxItems: 3
>>> +      - items:
>>> +          - description: Syscon to TCSR system registers
>>> +          - description: Perst enable offset
>>> +          - description: Perst separateion enable offset
>>
>> Unfortunately this still complains:
>>
>> qcom-sdx55-t55.dtb: pcie-ep@...00000: qcom,perst-regs:0: [28] is too short
>>
>>
>> where 28 is the phandle...
> 
> Meaning the dt is wrong or there's a tooling issue?

I think tooling issue. I looked at this many times and code (schema and
DTS) seems to be correct, but tool doesn't like it.


Best regards,
Krzysztof