[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YyC9N62JaMGaeanf@smile.fi.intel.com>
Date: Tue, 13 Sep 2022 20:26:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Raul E Rangel <rrangel@...omium.org>
Cc: linux-acpi@...r.kernel.org, linux-input@...r.kernel.org,
jingle.wu@....com.tw, mario.limonciello@....com, timvp@...gle.com,
linus.walleij@...aro.org, hdegoede@...hat.com, rafael@...nel.org,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set
wake_irq
On Mon, Sep 12, 2022 at 04:13:11PM -0600, Raul E Rangel wrote:
> Device tree already has a mechanism to pass the wake_irq. It does this
> by looking for the wakeup-source property and setting the
> I2C_CLIENT_WAKE flag. This CL adds the ACPI equivalent. It uses the
> ACPI interrupt wake flag to determine if the interrupt can be used to
> wake the system. Previously the i2c drivers had to make assumptions and
> blindly enable the wake IRQ. This can cause spurious wake events. e.g.,
> If there is a device with an Active Low interrupt and the device gets
> powered off while suspending, the interrupt line will go low since it's
> no longer powered and wakes the system. For this reason we should
> respect the board designers wishes and honor the wake bit defined on the
> interrupt.
...
> + if (irq > 0 && acpi_wake_capable)
> + client->flags |= I2C_CLIENT_WAKE;
Why do we need a parameter and can't simply set this flag inside the callee?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists