linux-kernel - Re: [EXT] Re: [PATCH v9 2/4] irqchip: Add IMX MU MSI controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871qsfuq2j.wl-maz@kernel.org>
Date:   Tue, 13 Sep 2022 18:44:36 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Frank Li <frank.li@....com>
Cc:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kw@...ux.com" <kw@...ux.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Peng Fan <peng.fan@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "jdmason@...zu.us" <jdmason@...zu.us>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "kishon@...com" <kishon@...com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "ntb@...ts.linux.dev" <ntb@...ts.linux.dev>,
        "lznuaa@...il.com" <lznuaa@...il.com>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
        "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>
Subject: Re: [EXT] Re: [PATCH v9 2/4] irqchip: Add IMX MU MSI controller driver

On Mon, 12 Sep 2022 16:53:40 +0100,
Frank Li <frank.li@....com> wrote:
> 
> > > [Frank Li] I remember you said that irq-chip can't be removed.
> > > So I am not sure why need build as module.
> > 
> > Not being removed doesn't mean it cannot be built as a module and
> > loaded on demand. Why should I be forced to have this driver built-in
> > if my kernel is used on a variety of systems, only one of them having
> > this device?
> 
> [Frank Li] A problem, platform_msi_create_irq_domain have NOT export
> to let module Call it.
> https://elixir.bootlin.com/linux/latest/source/drivers/base/platform-msi.c#L122
> 
> Do you want to me add EXPORT_SYMBOL_GPL for it  OR keep "bool" here? 

Please add a patch exporting the missing symbols, and make the think
modular.

	M.

-- 
Without deviation from the norm, progress is not possible.