linux-kernel - Re: [PATCH 0/4] Make QMI message rules const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b0543dc-4db8-aa33-d469-0e185c82b221@quicinc.com>
Date:   Tue, 13 Sep 2022 11:51:24 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Alex Elder <elder@...e.org>, Alex Elder <elder@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Kalle Valo <kvalo@...nel.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
CC:     <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/4] Make QMI message rules const

On 9/13/2022 6:58 AM, Alex Elder wrote:
> On 9/12/22 6:25 PM, Jeff Johnson wrote:
>> Change ff6d365898d ("soc: qcom: qmi: use const for struct
>> qmi_elem_info") allows QMI message encoding/decoding rules to be
>> const. So now update the definitions in the various client to take
>> advantage of this. Patches for ath10k and ath11k were perviously sent
>> separately.
> 
> I have had this on my "to-do list" for ages.
> The commit you mention updates the code to be
> explicit about not modifying this data, which
> is great.
> 
> I scanned over the changes, and I assume that
> all you did was make every object having the
> qmi_elem_info structure type be defined as
> constant.
> 
> Why aren't you changing the "ei_array" field in
> the qmi_elem_info structure to be const?  Or the
> "ei" field of the qmi_msg_handler structure?  And
> the qmi_response_type_v01_ei array (and so on)?
> 
> I like what you're doing, but can you comment
> on what your plans are beyond this series?
> Do you intend to make the rest of these fields
> const?

Hi Alex,
My primary focus is the ath* wireless drivers, and my primary goal was 
to make the tables there const. So this series, along with the two 
out-of-series patches for ath10k and ath11k complete that scope of work.

The lack of the other changes to the QMI data structures is simply due 
to me not looking in depth at the QMI code beyond the registration 
interface.

I'll be happy to revisit this as a separate cleanup.

/jeff