linux-kernel - Re: [PATCH 1/1] mtd: mtdpart: Fix cosmetic print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2022 09:37:21 +0200
From:   Rafał Miłecki <zajec5@...il.com>
To:     Adrian Zaharia <Adrian.Zaharia@...driver.com>,
        linux-mtd@...ts.infradead.org
Cc:     miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        jani.nurminen@...driver.com, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH 1/1] mtd: mtdpart: Fix cosmetic print

On 25.08.2022 08:04, Adrian Zaharia wrote:
> From: Jani Nurminen <jani.nurminen@...driver.com>
> 
> The print of the MTD partitions during boot are off-by-one for the size.
> Fix this and show the real last offset.

I see that PCI subsystem and printk() + %pR do that. Probably more. I
guess it makes sense but I'm also wondering if/how confusing is that
change going to be for users. We did printing like that for probably
dozens of years.


> Fixes: 3d6f657ced2b ("mtd: mtdpart: Fix cosmetic print")

I can't find that hash / commit anywhere. Are you sure it exists?


> Signed-off-by: Jani Nurminen <jani.nurminen@...driver.com>
> Signed-off-by: Adrian Zaharia <Adrian.Zaharia@...driver.com>
> ---
>   drivers/mtd/mtdpart.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index d442fa94c872..fab10e6d4171 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -118,7 +118,7 @@ static struct mtd_info *allocate_partition(struct mtd_info *parent,
>   		child->part.size = parent_size - child->part.offset;
>   
>   	printk(KERN_NOTICE "0x%012llx-0x%012llx : \"%s\"\n",
> -	       child->part.offset, child->part.offset + child->part.size,
> +	       child->part.offset, child->part.offset + child->part.size - 1,
>   	       child->name);
>   
>   	/* let's do some sanity checks */