[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b11e86c6-ff35-2103-cebe-ebe5f737d9de@arinc9.com>
Date: Tue, 13 Sep 2022 11:20:04 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc: Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
George McCollister <george.mccollister@...il.com>,
Kurt Kanzenbach <kurt@...utronix.de>,
Matthias Brugger <matthias.bgg@...il.com>,
Woojung Huh <woojung.huh@...rochip.com>,
UNGLinuxDriver@...rochip.com,
Linus Walleij <linus.walleij@...aro.org>,
Alvin Šipraga <alsi@...g-olufsen.dk>,
Clément Léger <clement.leger@...tlin.com>,
Landen Chao <Landen.Chao@...iatek.com>,
DENG Qingfang <dqfext@...il.com>,
Sean Wang <sean.wang@...iatek.com>,
Marek Vasut <marex@...x.de>, John Crispin <john@...ozen.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] dt-bindings: net: dsa: remove label = "cpu"
from examples
On 12.09.2022 20:50, Vladimir Oltean wrote:
> This is not used by the DSA dt-binding, so remove it from all examples.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
Acked-by: Arınç ÜNAL <arinc.unal@...nc9.com>
Is there also a plan to remove this from every devicetree on mainline
that has got this property on the CPU port?
I'd like to do the same on the DTs on OpenWrt.
Arınç
> ---
> Documentation/devicetree/bindings/net/dsa/ar9331.txt | 1 -
> .../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 1 -
> Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml | 2 --
> .../devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml | 1 -
> Documentation/devicetree/bindings/net/dsa/lan9303.txt | 2 --
> Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt | 1 -
> .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 7 -------
> .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 2 --
> Documentation/devicetree/bindings/net/dsa/qca8k.yaml | 3 ---
> Documentation/devicetree/bindings/net/dsa/realtek.yaml | 2 --
> .../devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml | 1 -
> .../devicetree/bindings/net/dsa/vitesse,vsc73xx.txt | 2 --
> 12 files changed, 25 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/ar9331.txt b/Documentation/devicetree/bindings/net/dsa/ar9331.txt
> index 320607cbbb17..f824fdae0da2 100644
> --- a/Documentation/devicetree/bindings/net/dsa/ar9331.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/ar9331.txt
> @@ -76,7 +76,6 @@ eth1: ethernet@...00000 {
>
> switch_port0: port@0 {
> reg = <0x0>;
> - label = "cpu";
> ethernet = <ð1>;
>
> phy-mode = "gmii";
> diff --git a/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml b/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> index eb01a8f37ce4..259a0c6547f3 100644
> --- a/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> @@ -61,7 +61,6 @@ examples:
> };
> ethernet-port@3 {
> reg = <3>;
> - label = "cpu";
> ethernet = <&fec1>;
> phy-mode = "rgmii-id";
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml b/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml
> index 2e01371b8288..1219b830b1a4 100644
> --- a/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml
> @@ -169,7 +169,6 @@ examples:
>
> port@8 {
> reg = <8>;
> - label = "cpu";
> phy-mode = "rgmii-txid";
> ethernet = <ð0>;
> fixed-link {
> @@ -252,7 +251,6 @@ examples:
>
> port@8 {
> ethernet = <&amac2>;
> - label = "cpu";
> reg = <8>;
> phy-mode = "internal";
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
> index 1ff44dd68a61..73b774eadd0b 100644
> --- a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
> @@ -91,7 +91,6 @@ examples:
>
> port@0 {
> reg = <0>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "mii";
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/lan9303.txt b/Documentation/devicetree/bindings/net/dsa/lan9303.txt
> index 464d6bf87605..46a732087f5c 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lan9303.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/lan9303.txt
> @@ -46,7 +46,6 @@ I2C managed mode:
>
> port@0 { /* RMII fixed link to master */
> reg = <0>;
> - label = "cpu";
> ethernet = <&master>;
> };
>
> @@ -83,7 +82,6 @@ MDIO managed mode:
>
> port@0 {
> reg = <0>;
> - label = "cpu";
> ethernet = <&master>;
> };
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt b/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
> index e3829d3e480e..8bb1eff21cb1 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
> @@ -96,7 +96,6 @@ switch@...8000 {
>
> port@6 {
> reg = <0x6>;
> - label = "cpu";
> ethernet = <ð0>;
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index 84bb36cab518..bc6446e1f55a 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -325,7 +325,6 @@ examples:
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "rgmii";
>
> @@ -389,7 +388,6 @@ examples:
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "trgmii";
>
> @@ -454,7 +452,6 @@ examples:
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "2500base-x";
>
> @@ -521,7 +518,6 @@ examples:
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "trgmii";
>
> @@ -610,7 +606,6 @@ examples:
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "trgmii";
>
> @@ -699,7 +694,6 @@ examples:
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "trgmii";
>
> @@ -787,7 +781,6 @@ examples:
>
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "trgmii";
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 456802affc9d..4da75b1f9533 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -107,7 +107,6 @@ examples:
> };
> port@5 {
> reg = <5>;
> - label = "cpu";
> ethernet = <ð0>;
> phy-mode = "rgmii";
>
> @@ -146,7 +145,6 @@ examples:
> };
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <ð0>;
> phy-mode = "rgmii";
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
> index f3c88371d76c..978162df51f7 100644
> --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
> @@ -159,7 +159,6 @@ examples:
>
> port@0 {
> reg = <0>;
> - label = "cpu";
> ethernet = <&gmac1>;
> phy-mode = "rgmii";
>
> @@ -221,7 +220,6 @@ examples:
>
> port@0 {
> reg = <0>;
> - label = "cpu";
> ethernet = <&gmac1>;
> phy-mode = "rgmii";
>
> @@ -268,7 +266,6 @@ examples:
>
> port@6 {
> reg = <0>;
> - label = "cpu";
> ethernet = <&gmac1>;
> phy-mode = "sgmii";
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> index 4f99aff029dc..1a7d45a8ad66 100644
> --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> @@ -189,7 +189,6 @@ examples:
> };
> port@5 {
> reg = <5>;
> - label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "rgmii";
> fixed-link {
> @@ -277,7 +276,6 @@ examples:
> };
> port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&fec1>;
> phy-mode = "rgmii";
> tx-internal-delay-ps = <2000>;
> diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> index 14a1f0b4c32b..7ca9c19a157c 100644
> --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> @@ -130,7 +130,6 @@ examples:
> port@4 {
> reg = <4>;
> ethernet = <&gmac2>;
> - label = "cpu";
> phy-mode = "internal";
>
> fixed-link {
> diff --git a/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt b/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt
> index bbf4a13f6d75..258bef483673 100644
> --- a/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt
> @@ -75,7 +75,6 @@ switch@0 {
> };
> vsc: port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&gmac1>;
> phy-mode = "rgmii";
> fixed-link {
> @@ -117,7 +116,6 @@ switch@2,0 {
> };
> vsc: port@6 {
> reg = <6>;
> - label = "cpu";
> ethernet = <&enet0>;
> phy-mode = "rgmii";
> fixed-link {
Powered by blists - more mailing lists