linux-kernel - Re: [PATCH] interconnect: qcom: Add the missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d47faa55-9b3e-022a-c074-080ddbe0658b@quicinc.com>
Date:   Tue, 13 Sep 2022 16:30:50 +0800
From:   Huang Yiwei <quic_hyiwei@...cinc.com>
To:     Leo Yan <leo.yan@...aro.org>
CC:     <agross@...nel.org>, <bjorn.andersson@...aro.org>,
        <konrad.dybcio@...ainline.org>, <djakov@...nel.org>,
        <dmitry.baryshkov@...aro.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] interconnect: qcom: Add the missing MODULE_LICENSE

Hi Leo,

On 9/13/2022 Tue 15:08, Leo Yan wrote:
> Hi Yiwei,
> 
> On Tue, Sep 13, 2022 at 02:27:21PM +0800, Huang Yiwei wrote:
>> Since icc-common.c can be compiled as module, add the missing
>> MODULE_LICENSE to avoid compile errors.
> 
> Just curious how you can enable config INTERCONNECT_QCOM as "m"
> (module)?
> 
> I checked the config INTERCONNECT_QCOM which is dependent on
> INTERCONNECT, and INTERCONNECT has below dependency:
> 
>    - DRM_TEGRA [=n] && HAS_IOMEM [=y] && (ARCH_TEGRA [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && DRM [=m] && OF [=y]
>    - TEGRA_MC [=n] && MEMORY [=y] && (ARCH_TEGRA [=y] || COMPILE_TEST [=n] && COMMON_CLK [=y])
> 
> Seems to me, it's impossible to enable INTERCONNECT as "m" because the
> dependency ARCH_TEGRA/OF/COMMON_CLK cannot be configured as "m".
> 
> Thanks,
> Leo
> 
Found the problem, INTERCONNECT_QCOM is modified to tristate internally
so we can compile it as a module, and the new added icc-common.c uses
INTERCONNECT_QCOM config to compile, then cause the problem. So shall we
change INTERCONNECT_QCOM config to tristate?

Thanks,
Yiwei