linux-kernel - Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220913105734.GD25849@workstation>
Date:   Tue, 13 Sep 2022 16:27:34 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        konrad.dybcio@...ainline.org, krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, johan+linaro@...nel.org,
        steev@...i.org
Subject: Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location

On Tue, Sep 13, 2022 at 12:07:32PM +0200, Johan Hovold wrote:
> [ Resend with Bjorn's address updated as the Linaro one now bounces. ]
> 
> On Tue, Sep 13, 2022 at 11:10:30AM +0530, Manivannan Sadhasivam wrote:
> > The firmware location in linux-firmware has been changed to include the
> > SoC name. So use the updated location in Thinkpad devicetree.
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> I guess we should pick a commit prefix that we stick to for changes to
> this driver.
> 
> 	arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s:
> 
> is arguably unnecessarily long even if it follows the pattern of some
> other qcom dts.
> 
> Shall we just use
> 
> 	arm64: dts: qcom: sc8280xp-x13s:

This looks looks better. I did look into the earlier commits but I found
the prefix to be too long, so went with the last commit prefix.

> 
> which matches sc8280xp-crd? Or stick "lenovo" in there as well? Or just
> keep the whole thing unchanged?
> 
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > index c379650e52b1..3b7943d6e164 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > @@ -554,13 +554,13 @@ keyboard@68 {
> >  };
> >  
> >  &remoteproc_adsp {
> > -	firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
> > +	firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
> >  
> >  	status = "okay";
> >  };
> >  
> >  &remoteproc_nsp0 {
> > -	firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
> > +	firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
> >  
> >  	status = "okay";
> >  };
> 
> Change itself looks good otherwise:
> 
> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
> 

Thanks! I will respin with the agreed prefix.

Regards,
Mani

> Johan