linux-kernel - Re: [PATCH V2 0/3] kprobe: Optimize the performance of patching ss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220913201909.2c7e38a40e719461e3c19b12@kernel.org>
Date:   Tue, 13 Sep 2022 20:19:09 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Liao Chang <liaochang1@...wei.com>
Cc:     <catalin.marinas@....com>, <will@...nel.org>, <guoren@...nel.org>,
        <paul.walmsley@...ive.com>, <palmer@...belt.com>,
        <aou@...s.berkeley.edu>, <rostedt@...dmis.org>, <maz@...nel.org>,
        <alexandru.elisei@....com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-csky@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH V2 0/3] kprobe: Optimize the performance of patching ss

On Tue, 13 Sep 2022 11:34:51 +0800
Liao Chang <liaochang1@...wei.com> wrote:

> Single-step slot would not be used until kprobe is enabled, that means
> no race condition occurs on it under SMP, hence it is safe to pacth ss
> slot without stopping machine.

All these patches look good to me, since single-step slot must not
be executed until it is prepared.

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
for this series.

But I need Ack by each architecture maintainer.

Thank you,

> 
> v2:
> Backport riscv patch to cksy and arm64.
> 
> Liao Chang (3):
>   riscv/kprobe: Optimize the performance of patching single-step slot
>   csky/kprobe: Optimize the performance of patching single-step slot
>   arm64/kprobe: Optimize the performance of patching single-step slot
> 
>  arch/arm64/kernel/probes/kprobes.c | 5 ++---
>  arch/csky/kernel/probes/kprobes.c  | 6 +++++-
>  arch/riscv/kernel/probes/kprobes.c | 8 +++++---
>  3 files changed, 12 insertions(+), 7 deletions(-)
> 
> -- 
> 2.17.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>