linux-kernel - Re: [PATCH char-misc-next] misc: microchip: pci1xxxx: use DEFINE_SIMPLE_DEV_PM_OPS() in place of the SIMPLE_DEV_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d34d9264-1f0b-d465-bc1d-75f8c736a35b@gmail.com>
Date:   Tue, 13 Sep 2022 20:44:40 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>,
        linux-kernel@...r.kernel.org, sudipm.mukherjee@...il.com,
        arnd@...db.de, linux-gpio@...r.kernel.org,
        linux-next@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH char-misc-next] misc: microchip: pci1xxxx: use
 DEFINE_SIMPLE_DEV_PM_OPS() in place of the SIMPLE_DEV_PM_OPS() in pci1xxxx's
 gpio driver

On 9/12/22 18:36, Kumaravel Thiagarajan wrote:
> build errors listed below and reported for the builds of
> riscv, s390, csky, alpha and loongarch allmodconfig are fixed in
> this patch.
> 
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
>   311 | static int pci1xxxx_gpio_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
>   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~
> 

What about this description?:

"Sudip reported unused function errors on riscv, s390, cksy, alpha,
and loongarch (allmodconfig):
<pci1xxxx_gpio_* errors>...

Fix these errors by using DEFINE_SIMPLE_DEV_PM_OPS."

> Fixes: 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")
> Reported-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>
> ---
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> index 9cc771c604ed..4cd541166b0c 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> @@ -405,7 +405,7 @@ static int pci1xxxx_gpio_probe(struct auxiliary_device *aux_dev,
>  	return devm_gpiochip_add_data(&aux_dev->dev, &priv->gpio, priv);
>  }
>  
> -static SIMPLE_DEV_PM_OPS(pci1xxxx_gpio_pm_ops, pci1xxxx_gpio_suspend, pci1xxxx_gpio_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(pci1xxxx_gpio_pm_ops, pci1xxxx_gpio_suspend, pci1xxxx_gpio_resume);
>  
>  static const struct auxiliary_device_id pci1xxxx_gpio_auxiliary_id_table[] = {
>  	{.name = "mchp_pci1xxxx_gp.gp_gpio"},


-- 
An old man doll... just what I always wanted! - Clara