linux-kernel - Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <075c234a-87bc-b479-366d-6bfc2731b3d5@huawei.com>
Date:   Tue, 13 Sep 2022 11:14:02 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <akpm@...ux-foundation.org>, <david@...hat.com>,
        <osalvador@...e.de>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK

On 2022/9/10 3:37, Matthew Wilcox wrote:
> On Fri, Sep 09, 2022 at 05:24:38PM +0800, Miaohe Lin wrote:
>> Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass
>> during bulk free"), it's not used anymore. Remove it.
> 
> Yes, but this patch needs to go further.  The comment is no longer true
> (after the patch you mention), so need to also delete these lines:
> 
> -/*
> - * Shift to encode migratetype and order in the same integer, with order
> - * in the least significant bits.
> - */
> -#define NR_PCP_ORDER_WIDTH 8
> 
> and the line:
> -                BUILD_BUG_ON(MAX_ORDER >= (1<<NR_PCP_ORDER_WIDTH));
> 

Agree. Many thanks for pointing this out. Will do it in next version.

Thanks,
Miaohe Lin

> 
> .
>