linux-kernel - Re: [PATCH v1] scsi: ufs: add a variant operation in struct ufs_hba_variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2022 11:30:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     SEO HOYOUNG <hy50.seo@...sung.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, alim.akhtar@...sung.com,
        avri.altman@....com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, beanhuo@...ron.com,
        asutoshd@...eaurora.org, cang@...eaurora.org, bvanassche@....org,
        bhoon95.kim@...sung.com, kwmad.kim@...sung.com
Cc:     kbuild-all@...ts.01.org, SEO HOYOUNG <hy50.seo@...sung.com>
Subject: Re: [PATCH v1] scsi: ufs: add a variant operation in struct
 ufs_hba_variant_ops

Hi SEO,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next krzk/for-next linus/master v6.0-rc5 next-20220912]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/SEO-HOYOUNG/scsi-ufs-add-a-variant-operation-in-struct-ufs_hba_variant_ops/20220913-101855
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20220913/202209131145.uQlsf9Uv-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/60f9cc2a287e2bfe58c8355519797a9071b00afa
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review SEO-HOYOUNG/scsi-ufs-add-a-variant-operation-in-struct-ufs_hba_variant_ops/20220913-101855
        git checkout 60f9cc2a287e2bfe58c8355519797a9071b00afa
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/ufs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/ufs/host/ufs-exynos.c: In function 'exynos_ufs_check_int_error':
   drivers/ufs/host/ufs-exynos.c:1388:17: error: 'val' undeclared (first use in this function)
    1388 |                 val = hci_readl(ufs, HCI_AH8_STATE);
         |                 ^~~
   drivers/ufs/host/ufs-exynos.c:1388:17: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/ufs/host/ufs-exynos.c:1392:40: warning: assignment to 'bool *' {aka '_Bool *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
    1392 |                          queue_eh_work = true;
         |                                        ^
>> drivers/ufs/host/ufs-exynos.c:1383:67: warning: parameter 'queue_eh_work' set but not used [-Wunused-but-set-parameter]
    1383 | static void exynos_ufs_check_int_error(struct ufs_hba *hba, bool *queue_eh_work)
         |                                                             ~~~~~~^~~~~~~~~~~~~


vim +1392 drivers/ufs/host/ufs-exynos.c

  1382	
> 1383	static void exynos_ufs_check_int_error(struct ufs_hba *hba, bool *queue_eh_work)
  1384	{
  1385		struct exynos_ufs *ufs = ufshcd_get_variant(hba);
  1386	
  1387		if (ufshcd_is_auto_hibern8_supported(hba)) {
  1388			val = hci_readl(ufs, HCI_AH8_STATE);
  1389	
  1390			if (val & HCI_AH8_STATE_ERROR) {
  1391				 ufshcd_set_link_broken(hba);
> 1392				 queue_eh_work = true;
  1393			}
  1394		}
  1395	}
  1396	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp