linux-kernel - Re: [PATCHv2 1/1] media: imx: Round line size to 4 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220914180904.73929b55.dorota.czaplejewicz@puri.sm>
Date:   Wed, 14 Sep 2022 18:09:04 +0200
From:   Dorota Czaplejewicz <dorota.czaplejewicz@...i.sm>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Steve Longerbeam <slongerbeam@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...i.sm, phone-devel@...r.kernel.org
Subject: Re: [PATCHv2 1/1] media: imx: Round line size to 4 bytes

On Wed, 14 Sep 2022 18:45:05 +0300
Dan Carpenter <dan.carpenter@...cle.com> wrote:

> On Wed, Sep 14, 2022 at 05:32:36PM +0200, Dorota Czaplejewicz wrote:
> > Section 13.7.6.13 "CSI Image Parameter Register" of the
> > i.MX 8M Quad Applications Processors Reference Manual
> > states that the line size should be divisible by 8 bytes.
> > However, the hardware also accepts sizes divisible by 4 bytes,
> > which are needed to fully utilize the S5K3L6XX sensors.
> > 
> > This patch accepts line sizes divisible 4-bytes in non-planar mode.
> > 
> > ---  
> 
> So do we need a Fixes tag?  Was this ever working in kernel?
> 
No, it wasn't actually ever working upstream, just in a patched up branch I mixed up with the real thing.
> Definitely need a Signed-off-by line, though. ;)

Thanks again!
--Dorota
> 
> regards,
> dan carpenter
> 


Content of type "application/pgp-signature" skipped