linux-kernel - Re: [PATCH v13 05/13] nvme: zns: Allow ZNS drives that have non-power_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdb385ee-25c9-a82b-2b36-92b5b2e5d198@nvidia.com>
Date:   Wed, 14 Sep 2022 17:16:43 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Pankaj Raghav <p.raghav@...sung.com>, "hch@....de" <hch@....de>,
        "agk@...hat.com" <agk@...hat.com>,
        "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "snitzer@...nel.org" <snitzer@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Johannes.Thumshirn@....com" <Johannes.Thumshirn@....com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "pankydev8@...il.com" <pankydev8@...il.com>,
        "matias.bjorling@....com" <matias.bjorling@....com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "bvanassche@....org" <bvanassche@....org>,
        "gost.dev@...sung.com" <gost.dev@...sung.com>,
        "dm-devel@...hat.com" <dm-devel@...hat.com>,
        "hare@...e.de" <hare@...e.de>,
        "jaegeuk@...nel.org" <jaegeuk@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH v13 05/13] nvme: zns: Allow ZNS drives that have
 non-power_of_2 zone size

On 9/12/2022 1:21 AM, Pankaj Raghav wrote:
> Remove the condition which disallows non-power_of_2 zone size ZNS drive
> to be updated and use generic method to calculate number of zones
> instead of relying on log and shift based calculation on zone size.
> 
> The power_of_2 calculation has been replaced directly with generic
> calculation without special handling. Both modified functions are not
> used in hot paths, they are only used during initialization &
> revalidation of the ZNS device.
> 
> As rounddown macro from math.h does not work for 32 bit architectures,
> round down operation is open coded.
> 
> Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>
> Reviewed by: Adam Manzanares <a.manzanares@...sung.com>
> Reviewed-by: Hannes Reinecke <hare@...e.de>
> Reviewed-by: Bart Van Assche <bvanassche@....org>
> Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
>


Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck