linux-kernel - Re: [PATCH] libbpf: adjust OPTS_VALID logic, so that it can be used correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2022 11:15:39 -0700
From:   Hao Luo <haoluo@...gle.com>
To:     Xin Liu <liuxin350@...wei.com>
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        martin.lau@...ux.dev, song@...nel.org, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com,
        jolsa@...nel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, yanan@...wei.com,
        wuchangye@...wei.com, xiesongyang@...wei.com, zhudi2@...wei.com,
        kongweibin2@...wei.com
Subject: Re: [PATCH] libbpf: adjust OPTS_VALID logic, so that it can be used correctly

Hi Xin,

On Wed, Sep 14, 2022 at 5:35 AM Xin Liu <liuxin350@...wei.com> wrote:
>
> We found that function btf_dump__dump_type_data can be called by the user
> as an api, but in this function, the `opts` parameter may be used as a
> null pointer, because OPTS_VALID can't properly prevent opts used as null
> pointers during verification. Therefore, we fix this problem through this
> modification.
>
> This modification has no impact on other places where OPTS_VALID has been
> used.

I think this is a bug of btf_dump__dump_type_data(), not OPTS_VALID.
It seems allowing OPTS_VALID to accept NULL is the intended behavior.

>
[...]
>