linux-kernel - Re: [PATCH] perf inject: Clarify build-id options a little bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2022 08:11:20 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Namhyung Kim <namhyung@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf inject: Clarify build-id options a little bit

On 14/09/22 07:08, Namhyung Kim wrote:
> Update the documentation of --build-id and --buildid-all options to
> clarify the difference between them.  The former requires full sample
> processing to find which DSOs are actually used.  While the latter simply
> injects every DSO's build-id from MMAP{,2} records, skipping SAMPLEs.
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Reviewed-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  tools/perf/Documentation/perf-inject.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-inject.txt b/tools/perf/Documentation/perf-inject.txt
> index 70e2ac3cc91a..c972032f4ca0 100644
> --- a/tools/perf/Documentation/perf-inject.txt
> +++ b/tools/perf/Documentation/perf-inject.txt
> @@ -25,10 +25,12 @@ OPTIONS
>  -------
>  -b::
>  --build-ids::
> -        Inject build-ids into the output stream
> +	Inject build-ids of DSOs hit by samples into the output stream.
> +	This means it needs to process all SAMPLE records to find the DSOs.
>  
>  --buildid-all::
> -	Inject build-ids of all DSOs into the output stream
> +	Inject build-ids of all DSOs into the output stream regardless of hits
> +	and skip SAMPLE processing.
>  
>  --known-build-ids=::
>  	Override build-ids to inject using these comma-separated pairs of