lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Sep 2022 09:34:55 +0800 From: Zeng Heng <zengheng4@...wei.com> To: Masahiro Yamada <masahiroy@...nel.org> CC: Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, <liwei391@...wei.com>, "weiyongjun (A)" <weiyongjun1@...wei.com> Subject: Re: [PATCH -next 1/2] Kconfig: remove unused argment 'ch' Yes, I would replace sym_set_choice_value with sym_set_tristate_value at v2. 在 2022/9/14 0:35, Masahiro Yamada 写道: > On Mon, Sep 12, 2022 at 6:41 PM Zeng Heng <zengheng4@...wei.com> wrote: >> Remove unused argment 'ch' in sym_set_choice_value >> >> Signed-off-by: Zeng Heng <zengheng4@...wei.com> > > Can you remove sym_set_choice_value() and > call sym_set_tristate_value(chval, yes) directly? > > > > > >> --- >> scripts/kconfig/conf.c | 2 +- >> scripts/kconfig/lkc.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c >> index 4178065ca27f..635265a18a07 100644 >> --- a/scripts/kconfig/conf.c >> +++ b/scripts/kconfig/conf.c >> @@ -551,7 +551,7 @@ static int conf_choice(struct menu *menu) >> print_help(child); >> continue; >> } >> - sym_set_choice_value(sym, child->sym); >> + sym_set_choice_value(child->sym); >> for (child = child->list; child; child = child->next) { >> indent += 2; >> conf(child); >> diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h >> index fa8c010aa683..279d56a44136 100644 >> --- a/scripts/kconfig/lkc.h >> +++ b/scripts/kconfig/lkc.h >> @@ -124,7 +124,7 @@ static inline struct symbol *sym_get_choice_value(struct symbol *sym) >> return (struct symbol *)sym->curr.val; >> } >> >> -static inline bool sym_set_choice_value(struct symbol *ch, struct symbol *chval) >> +static inline bool sym_set_choice_value(struct symbol *chval) >> { >> return sym_set_tristate_value(chval, yes); >> } >> -- >> 2.25.1 >> >
Powered by blists - more mailing lists