linux-kernel - Re: [PATCH V2 3/7] arm64/perf: Update struct pmu_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YyGgdPzJG3+0nCC4@sirena.org.uk>
Date:   Wed, 14 Sep 2022 10:35:48 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, peterz@...radead.org,
        acme@...nel.org, mark.rutland@....com, will@...nel.org,
        catalin.marinas@....com, James Clark <james.clark@....com>,
        Rob Herring <robh@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH V2 3/7] arm64/perf: Update struct pmu_hw_events for BRBE

On Wed, Sep 14, 2022 at 09:09:10AM +0530, Anshuman Khandual wrote:

> Something like the following change moves the buffer allocation off the stack,
> although it requires updating the driver, and buffer assignment during a PMU
> interrupt. But it does seem to work (will require some more testing).

Yeah, looks like it should do the trick.

> +
> +               events->branch_records = kmalloc(sizeof(struct brbe_records), flags);
> +               WARN_ON(!events->branch_records);

No need for the WARN_ON(), if we run out of memory the memory
management code is already very loud about it.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)