linux-kernel - Re: [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyGh6Yjbb/5rkh35@smile.fi.intel.com>
Date:   Wed, 14 Sep 2022 12:42:01 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Raul Rangel <rrangel@...omium.org>
Cc:     Linux ACPI <linux-acpi@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>,
        "jingle.wu" <jingle.wu@....com.tw>,
        "Limonciello, Mario" <mario.limonciello@....com>,
        Tim Van Patten <timvp@...gle.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Hans de Goede <hdegoede@...hat.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Wolfram Sang <wsa@...nel.org>,
        "open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set
 wake_irq

On Tue, Sep 13, 2022 at 12:56:37PM -0600, Raul Rangel wrote:
> On Tue, Sep 13, 2022 at 12:33 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Tue, Sep 13, 2022 at 12:07:53PM -0600, Raul Rangel wrote:

...

> > This is similar to what of_i2c_get_board_info() does, no?
> > Note: _get_ there.
> 
> `*info` is an out parameter in that case. Ideally I would have
> `i2c_acpi_get_irq`, `acpi_dev_gpio_irq_get_wake`,
> `platform_get_irq_optional`, and `i2c_dev_irq_from_resources` all
> return a `struct irq_info {int irq; bool wake_capable;}`. This would
> be a larger change though.

Seems the ACPI analogue is i2c_acpi_fill_info(). Can we do it there?

-- 
With Best Regards,
Andy Shevchenko