linux-kernel - Re: [PATCH v4 1/2] mm: hugetlb: simplify per-node sysfs creation and removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d14feb6-24a7-c114-c9c0-9ff3d8f4f448@redhat.com>
Date:   Wed, 14 Sep 2022 12:03:07 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Muchun Song <songmuchun@...edance.com>, gregkh@...uxfoundation.org,
        rafael@...nel.org, mike.kravetz@...cle.com,
        akpm@...ux-foundation.org, osalvador@...e.de, ying.huang@...el.com,
        aneesh.kumar@...ux.ibm.com, rientjes@...gle.com
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        muchun.song@...ux.dev, Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH v4 1/2] mm: hugetlb: simplify per-node sysfs creation and
 removal

On 14.09.22 09:26, Muchun Song wrote:
> The following commit offload per-node sysfs creation and removal to a
> kworker and did not say why it is needed.  And it also said "I don't know
> that this is absolutely required".  It seems like the author was not sure
> as well.  Since it only complicates the code, this patch will revert the
> changes to simplify the code.
> 
>    39da08cb074c ("hugetlb: offload per node attribute registrations")
> 
> We could use memory hotplug notifier to do per-node sysfs creation and
> removal instead of inserting those operations to node registration and
> unregistration.  Then, it can reduce the code coupling between node.c and
> hugetlb.c.  Also, it can simplify the code.
> 
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> Acked-by: Mike Kravetz <mike.kravetz@...cle.com>
> Cc: Andi Kleen <andi@...stfloor.org>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Muchun Song <songmuchun@...edance.com>
> Cc: Oscar Salvador <osalvador@...e.de>
> Cc: Rafael J. Wysocki <rafael@...nel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb