linux-kernel - Re: [PATCH v3] clocksource/drivers/arm_arch_timer: Fix handling of ARM erratum 858921

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyGqZmO9vibRmd8n@google.com>
Date:   Wed, 14 Sep 2022 11:18:14 +0100
From:   Oliver Upton <oliver.upton@...ux.dev>
To:     Kunkun Jiang <jiangkunkun@...wei.com>
Cc:     Mark Rutland <mark.rutland@....com>, Marc Zyngier <maz@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        wanghaibin.wang@...wei.com, yuzenghui@...wei.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] clocksource/drivers/arm_arch_timer: Fix handling of
 ARM erratum 858921

On Wed, Sep 14, 2022 at 02:14:24PM +0800, Kunkun Jiang wrote:
> The commit a38b71b0833e ("clocksource/drivers/arm_arch_timer:
> Move system register timer programming over to CVAL") moves the
> programming of the timers from the countdown timer (TVAL) over
> to the comparator (CVAL). This makes it necessary to read the
> counter when programming next event. However, the workaround of
> Cortex-A73 erratum 858921 does not set the corresponding
> set_next_event_phys and set_next_event_virt.
> 
> Add the appropriate hooks to apply the erratum mitigation when
> programming the next timer event.
> 
> Fixes: a38b71b0833e ("clocksource/drivers/arm_arch_timer: Move system register timer programming over to CVAL")
> Signed-off-by: Kunkun Jiang <jiangkunkun@...wei.com>
> Acked-by: Marc Zyngier <maz@...nel.org>

Reviewed-by: Oliver Upton <oliver.upton@...ux.dev>

--
Thanks,
Oliver