linux-kernel - Re: [PATCH 2/4] remoteproc: sysmon: Make QMI message rules const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c98d4256-0650-a3b8-4be2-713e0e27d434@quicinc.com>
Date:   Wed, 14 Sep 2022 15:54:41 +0530
From:   Sibi Sankar <quic_sibis@...cinc.com>
To:     Jeff Johnson <quic_jjohnson@...cinc.com>,
        Alex Elder <elder@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Mathieu Poirier" <mathieu.poirier@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Kalle Valo <kvalo@...nel.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "Konrad Dybcio" <konrad.dybcio@...ainline.org>
CC:     <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] remoteproc: sysmon: Make QMI message rules const



On 9/13/22 4:55 AM, Jeff Johnson wrote:
> Commit ff6d365898d ("soc: qcom: qmi: use const for struct
> qmi_elem_info") allows QMI message encoding/decoding rules to be
> const, so do that for sysmon.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

Reviewed-by: Sibi Sankar <quic_sibis@...cinc.com>

> ---
>   drivers/remoteproc/qcom_sysmon.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
> index 57dde2a69b9d..3992bb61d2ec 100644
> --- a/drivers/remoteproc/qcom_sysmon.c
> +++ b/drivers/remoteproc/qcom_sysmon.c
> @@ -190,7 +190,7 @@ struct ssctl_shutdown_resp {
>   	struct qmi_response_type_v01 resp;
>   };
>   
> -static struct qmi_elem_info ssctl_shutdown_resp_ei[] = {
> +static const struct qmi_elem_info ssctl_shutdown_resp_ei[] = {
>   	{
>   		.data_type	= QMI_STRUCT,
>   		.elem_len	= 1,
> @@ -211,7 +211,7 @@ struct ssctl_subsys_event_req {
>   	u32 evt_driven;
>   };
>   
> -static struct qmi_elem_info ssctl_subsys_event_req_ei[] = {
> +static const struct qmi_elem_info ssctl_subsys_event_req_ei[] = {
>   	{
>   		.data_type	= QMI_DATA_LEN,
>   		.elem_len	= 1,
> @@ -269,7 +269,7 @@ struct ssctl_subsys_event_resp {
>   	struct qmi_response_type_v01 resp;
>   };
>   
> -static struct qmi_elem_info ssctl_subsys_event_resp_ei[] = {
> +static const struct qmi_elem_info ssctl_subsys_event_resp_ei[] = {
>   	{
>   		.data_type	= QMI_STRUCT,
>   		.elem_len	= 1,
> @@ -283,7 +283,7 @@ static struct qmi_elem_info ssctl_subsys_event_resp_ei[] = {
>   	{}
>   };
>   
> -static struct qmi_elem_info ssctl_shutdown_ind_ei[] = {
> +static const struct qmi_elem_info ssctl_shutdown_ind_ei[] = {
>   	{}
>   };
>   
>