linux-kernel - Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87v8pqtevo.wl-tiwai@suse.de>
Date:   Wed, 14 Sep 2022 12:43:55 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     Gaosheng Cui <cuigaosheng1@...wei.com>, cezary.rojewski@...el.com,
        tiwai@...e.com, ranjani.sridharan@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, perex@...ex.cz,
        liam.r.girdwood@...ux.intel.com, kai.vehmanen@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, yung-chuan.liao@...ux.intel.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec

On Wed, 14 Sep 2022 12:31:23 +0200,
Mark Brown wrote:
> 
> On Wed, Sep 14, 2022 at 12:27:28PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > [1/1] ASoC: Intel: fix unused-variable warning in probe_codec
> > >       commit: 515626a33a194c4caaf2879dbf9e00e882582af0
> 
> > I thought the buggy commit 3fd63658caed9 was present only in my tree
> > for now, but if it's in your tree, that's fine to apply through
> > yours.  Then I'll drop from mine.
> 
> Huh, right - I think you're right here and it is only in your
> tree, it just didn't trigger any issues in my coverage tests
> prior to merge.  Probably best to leave it in your tree and
> either have a double apply or I'll revert it from mine.  Either
> way it'll get fixed by the time it gets sent to Linus.
>
> I'd not remembered that you had any extra stuff for ASoC in your
> tree, sorry.

No problem, it was rather an exception.

I don't mind to keep in both trees; it should be resolved at the merge
of ASoC tree before the PR to Linus, if any.


thanks,

Takashi