linux-kernel - [PATCH] ntfs3: Fix memory leak in ntfs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220914111643.14411-1-code@siddh.me>
Date:   Wed, 14 Sep 2022 16:46:43 +0530
From:   Siddh Raman Pant <code@...dh.me>
To:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
Cc:     ntfs3 <ntfs3@...ts.linux.dev>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        syzbot+9d67170b20e8f94351c8@...kaller.appspotmail.com,
        stable@...r.kernel.org
Subject: [PATCH] ntfs3: Fix memory leak in ntfs_fill_super()

Mount options ptr wasn't freed before putting the superblock in
ntfs_fill_super(), which resulted in a memory leak.

Bug report: https://syzkaller.appspot.com/bug?id=332ba47915d0e39e94b42a622f195f0804ecb67f

Fixes: 9b75450d6c58 ("fs/ntfs3: Fix memory leak if fill_super failed")
Reported-and-tested-by: syzbot+9d67170b20e8f94351c8@...kaller.appspotmail.com
Cc: stable@...r.kernel.org # 5.15
Signed-off-by: Siddh Raman Pant <code@...dh.me>
---
 fs/ntfs3/super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 47012c9bf505..c0e45f170701 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1281,6 +1281,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	 * Free resources here.
 	 * ntfs_fs_free will be called with fc->s_fs_info = NULL
 	 */
+	put_mount_options(sbi->options);
 	put_ntfs(sbi);
 	sb->s_fs_info = NULL;
 
-- 
2.35.1