linux-kernel - Re: [PATCH] net: ethernet: litex: Fix return type of liteeth_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyHD4MX0Pvckb6XW@errol.ini.cmu.edu>
Date:   Wed, 14 Sep 2022 08:06:56 -0400
From:   "Gabriel L. Somlo" <gsomlo@...il.com>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Nathan Huckleberry <nhuck@...gle.com>,
        Dan Carpenter <error27@...il.com>, llvm@...ts.linux.dev,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Joel Stanley <joel@....id.au>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: litex: Fix return type of
 liteeth_start_xmit

On Tue, Sep 13, 2022 at 03:31:11PM -0700, Nathan Chancellor wrote:
> On Mon, Sep 12, 2022 at 12:53:07PM -0700, Nathan Huckleberry wrote:
> > The ndo_start_xmit field in net_device_ops is expected to be of type
> > netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).
> > 
> > The mismatched return type breaks forward edge kCFI since the underlying
> > function definition does not match the function hook definition.
> > 
> > The return type of liteeth_start_xmit should be changed from int to
> > netdev_tx_t.
> > 
> > Reported-by: Dan Carpenter <error27@...il.com>
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> > Cc: llvm@...ts.linux.dev
> > Signed-off-by: Nathan Huckleberry <nhuck@...gle.com>
> 
> Reviewed-by: Nathan Chancellor <nathan@...nel.org>

Acked-by: Gabriel Somlo <gsomlo@...il.com>

Thanks,
--G

 
> > ---
> >  drivers/net/ethernet/litex/litex_liteeth.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
> > index fdd99f0de424..35f24e0f0934 100644
> > --- a/drivers/net/ethernet/litex/litex_liteeth.c
> > +++ b/drivers/net/ethernet/litex/litex_liteeth.c
> > @@ -152,7 +152,8 @@ static int liteeth_stop(struct net_device *netdev)
> >  	return 0;
> >  }
> >  
> > -static int liteeth_start_xmit(struct sk_buff *skb, struct net_device *netdev)
> > +static netdev_tx_t liteeth_start_xmit(struct sk_buff *skb,
> > +				      struct net_device *netdev)
> >  {
> >  	struct liteeth *priv = netdev_priv(netdev);
> >  	void __iomem *txbuffer;
> > -- 
> > 2.37.2.789.g6183377224-goog
> >