linux-kernel - Re: [PATCH] xhci: Don't show warning for reinit on known broken suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02ef1ae2-9dae-6f02-9951-1230939f06e2@linux.intel.com>
Date:   Wed, 14 Sep 2022 15:28:09 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Mario Limonciello <mario.limonciello@....com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Puma Hsu <pumahsu@...gle.com>
Cc:     "Artem S . Tashkinov" <aros@....com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci: Don't show warning for reinit on known broken
 suspend

On 13.9.2022 23.35, Mario Limonciello wrote:
> commit 8b328f8002bc ("xhci: re-initialize the HC during resume if HCE was
> set") introduced a new warning message when the host controller error
> was set and re-initializing.
> 
> This is expected behavior on some designs which already set
> `xhci->broken_suspend` so the new warning is alarming to some users.
> 
> Modify the code to only show the warning if this was a surprising behavior
> to the XHCI driver.
> 
> Fixes: 8b328f8002bc ("xhci: re-initialize the HC during resume if HCE was set")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216470
> Reported-by: Artem S. Tashkinov <aros@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---

Thanks, adding to queue

-Mathias