linux-kernel - Re: [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2022 05:32:51 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jerome Neanne <jneanne@...libre.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        nm@...com, kristo@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        catalin.marinas@....com, will@...nel.org, lee.jones@...aro.org,
        tony@...mide.com, afd@...com, khilman@...libre.com,
        narmstrong@...libre.com, msp@...libre.com, j-keerthy@...com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton

Hi Jerome,

On Tue, Sep 13, 2022 at 02:14:18PM +0200, Jerome Neanne wrote:
> +	idev = devm_input_allocate_device(dev);
> +	if (!idev)
> +		return -ENOMEM;
> +
> +	idev->name = pdev->name;
> +	snprintf(pwr->phys, sizeof(pwr->phys), "%s/input0",
> +		 pdev->name);
> +	idev->phys = pwr->phys;
> +	idev->dev.parent = dev;

This assignment is not needed given that devm_input_allocate_device()
is used. Otherwise:

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Please feel free to merge through MFD tree.

Thanks.

-- 
Dmitry