linux-kernel - Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyHMvBhWgbDtv6V2@rocinante>
Date:   Wed, 14 Sep 2022 21:44:44 +0900
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Jon Hunter <jonathanh@...dia.com>, Vidya Sagar <vidyas@...dia.com>,
        Bjorn Helgaas <helgaas@...nel.org>, jingoohan1@...il.com,
        gustavo.pimentel@...opsys.com, lpieralisi@...nel.org,
        robh@...nel.org, bhelgaas@...gle.com, treding@...dia.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        kthota@...dia.com, mmaddireddy@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event
 logging

Hello,

[...]
> Anyway, I don't strongly object the change and leave it to the
> maintainers to decide.

Perhaps it makes sense to make this a dev_dbg() over dev_info(), especially
since it appears that this information is of more use to the developer (who
most likely has the suitable log level set anyway), and given that there is
no way to reliably detect a presence in a slot on some platforms, this
might otherwise, add to the other messages that normal users don't pay
attention to usually - if this is not to be treated as an error.

	Krzysztof