linux-kernel - Re: [PATCH] mfd: htc-i2cpld: Fix an IS_ERR() vs NULL bug in htcpld_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2022 14:50:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Peng Wu <wupeng58@...wei.com>
Cc:     lee@...nel.org, linux-kernel@...r.kernel.org, liwei391@...wei.com
Subject: Re: [PATCH] mfd: htc-i2cpld: Fix an IS_ERR() vs NULL bug in htcpld_core_probe

On Tue, Sep 13, 2022 at 9:19 AM Peng Wu <wupeng58@...wei.com> wrote:

> The gpiochip_request_own_desc() function returns error pointers on error,
> it doesn't return NULL.
>
> Fixes: 0ef5164a81fbf ("mfd/omap1: htc-i2cpld: Convert to a pure GPIO driver")
> Signed-off-by: Peng Wu <wupeng58@...wei.com>

Good catch!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij