linux-kernel - RE: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR12MB43330B57F5CFBEC35105665188469@MN2PR12MB4333.namprd12.prod.outlook.com>
Date:   Wed, 14 Sep 2022 13:15:00 +0000
From:   "Mehta, Piyush" <piyush.mehta@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "balbi@...nel.org" <balbi@...nel.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Simek, Michal" <michal.simek@....com>,
        "Paladugu, Siva Durga Prasad" <siva.durga.prasad.paladugu@....com>,
        Manish Narani <manish.narani@...inx.com>
Subject: RE: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include
 hibernation interrupt

Hello Krzysztof,

Thanks for the review comments.

Please find my inline comments with tag [Piyush].

Regards,
Piyush Mehta

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Tuesday, September 13, 2022 2:52 PM
> To: Mehta, Piyush <piyush.mehta@....com>; gregkh@...uxfoundation.org;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org; balbi@...nel.org
> Cc: linux-usb@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; Simek, Michal <michal.simek@....com>; Paladugu,
> Siva Durga Prasad <siva.durga.prasad.paladugu@....com>; Manish Narani
> <manish.narani@...inx.com>
> Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include
> hibernation interrupt
> 
> On 12/09/2022 10:57, Piyush Mehta wrote:
> > From: Manish Narani <manish.narani@...inx.com>
> >
> > The hibernation feature enabled for Xilinx ZynqMP SoC in DWC3 IP.
> > Added the below interrupt-names in the binding schema for the same.
> >
> > dwc_usb3: dwc3 core interrupt-names
> > otg: otg interrupt-names
> > hiber: hibernation interrupt-names
> 
> This does not make sense in commit msg. Don't duplicate patch in commit
> msg.
[Piyush]:
Will rephrase the commit message and send V2.
 
> Where is the user (DTS) and implementation of this change? If this is specific
> to Xilinx, why you do not have device specific compatible?
[Piyush]:
We have dedicated irq line for hibernation feature,  "hiber" irq line triggers hibernation interrupt.
DWC3 core supports the hibernation feature, we have a dedicated code which is yet to be upstreamed.
As the hibernation feature provided by dwc3-core, so this will be supported by other SOC/vendors.

> 
> >
> > Signed-off-by: Manish Narani <manish.narani@...inx.com>
> > Signed-off-by: Piyush Mehta <piyush.mehta@....com>
> > ---
> >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > index 1779d08ba1c0..618fa7bd32be 100644
> > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > @@ -53,6 +53,8 @@ properties:
> >        - const: dwc_usb3
> >        - items:
> >            enum: [host, peripheral, otg]
> > +      - items:
> > +          enum: [dwc_usb3, otg, hiber]
> 
> 
> 
> Best regards,
> Krzysztof