linux-kernel - Re: [PATCH v2 2/2] mm/page_io: count submission time as thrashing delay for delayacct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAmzW4ORH=kMbzMg7tpGTF_0Ky4Rb1TZ+W=q=pgppNaRxkScQQ@mail.gmail.com>
Date:   Wed, 14 Sep 2022 23:49:35 +0900
From:   Joonsoo Kim <js1304@...il.com>
To:     cgel.zte@...il.com
Cc:     akpm@...ux-foundation.org, iamjoonsoo.kim@....com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Yang Yang <yang.yang29@....com.cn>,
        Ran Xiaokai <ran.xiaokai@....com.cn>,
        wangyong <wang.yong12@....com.cn>
Subject: Re: [PATCH v2 2/2] mm/page_io: count submission time as thrashing
 delay for delayacct

2022년 8월 15일 (월) 오후 4:33, <cgel.zte@...il.com>님이 작성:
>
> From: Yang Yang <yang.yang29@....com.cn>
>
> Once upon a time, we only support accounting thrashing of page cache.
> Then Joonsoo introduced workingset detection for anonymous pages and
> we gained the ability to account thrashing of them[1].
>
> Likes PSI, we count submission time as thrashing delay because when
> the device is congested, or the submitting cgroup IO-throttled,
> submission can be a significant part of overall IO time.

It's not the main purpose of this patch. Without this patch,
swap thrashing through frontswap or some block device supporting rw_page
operation isn't measured correctly. I think that description change is
required. Please refer to commit 937790699be9c8100e
(mm/page_io.c: annotate refault stalls from swap_readpage).

No objection on the code side.

Thanks.